Cheshire Cat Computing

i use NagiosEventLog 1.9.2 on five copies of Windows Server 2003 R2 SP2 Russian (!) 32 bit
i check source code, included in distr (1.9.0.0 ?), and found some bugs...

1. bad registry record

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\Eventlog\Application\NagiosEventLog]
"TypesSupported"=dword:00000007
"EventMessageFile"=-
"EventMessageFile"="C:\\Program Files\\Monitoring\\msgdll.dll"

2. multiple errors in ntsl.c
2.1. bug in function sendheartbeat(), uninitialized e.filter variable
2.2. bugs with third parameter in _vsnprintf_s, i think we must use _TRANCATE (but i may be wrong)
2.3. bug in functions ntsl_log_msg(), ntsl_log_msg have _vsnprintf_s, which unusable at all, it never receive third parameter !

full ntsl.c attached to this message. and do not forget to change ntsl.h =)

Thanks for this, I'll take a look and compare with current source tree. It will probably make sense once I can see the source code

Not sure about the registry entry. The msgdll should be registered so that the eventlog can correctly display the nagevlog messages.

_________________
Steve Shipway
UNIX Systems, ITSS, University of Auckland, NZ
Woe unto them that rise up early in the morning... -- Isaiah 5:11